Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor XMLUtil #2

Open
hiroshinoji opened this issue Mar 12, 2015 · 0 comments
Open

Refactor XMLUtil #2

hiroshinoji opened this issue Mar 12, 2015 · 0 comments
Assignees
@hiroshinoji
Labels
enhancement

Comments

@hiroshinoji
Copy link
Contributor

Current implementation of removeText:
https://github.com/mynlp/jigg/blob/master/src/main/scala/jigg/util/XMLUtil.scala#L46

seems problematic. This code cannot handle some Elem object which has more than one Atom[_] elements. Maybe we can refactor this method based on pattern match with XML literal(?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hiroshinoji hiroshinoji

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hiroshinoji