Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZA] Make the province list page more inviting #2476

Open
zarino opened this issue Sep 6, 2018 · 5 comments
Open

[ZA] Make the province list page more inviting #2476

zarino opened this issue Sep 6, 2018 · 5 comments

Comments

@zarino
Copy link
Member

zarino commented Sep 6, 2018

https://www.pa.org.za/place/is/province/ looks sad.

screenshot_2018-09-06 people s assembly 1

PMG are going to investigate whether they can legally use the province coats of arms as thumbnail images here, to replace the “push pin” placeholder images.

But in the meantime, is there anything else we can do to make this page more tantalising?

@GeorgieBurr
Copy link

Meghan and Gaile fedback today that the only Legislature pictures they can access are very large 90x90, and wanted to check if you can work with pictures that big?

If you can’t, then let them know as they will have an internal discussion about an alternative :)

@zarino
Copy link
Member Author

zarino commented Oct 19, 2018

Megan has sent me some photos of the primary buildings in each legislature. I’m going to crop them down to squares.

In the meantime, @GeorgieBurr, a bit of digging has revealed that there’s actually a technical blocker to getting these images in place – #2496 – so we’ll need to make a decision on that before this ticket can be dealt with.

@GeorgieBurr
Copy link

2 days

@chrismytton
Copy link
Member

#2496 has been fixed, so places can now have images associated with them in the same way as people and orgs.


As a bonus it turns out that the place list item template already handles generating a thumbnail, so you can add an images to a province and it will automatically show up on the list of provinces:

{% thumbnail object.primary_image "90x90" crop="center" as im %}
<a href="{{ object.get_absolute_url }}">
<img src="{{ im.url }}" width="{{ im.width }}" height="{{ im.height }}"/>
</a>
{% empty %}
<a href="{{ object.get_absolute_url }}">
<img src="{% static 'images/place-90x90.jpg' %}" />
</a>
{% endthumbnail %}

image

@chrismytton
Copy link
Member

Megan has sent me some photos of the primary buildings in each legislature. I’m going to crop them down to squares.

I've now uploaded these images to the individual places, so the province list page now shows place thumbnails.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants