[ZA] Missing tabs on MP profiles

[chrismytton]

Request from Megan:

Some of the MP profiles have missing tabs, e.g.

https://www.pa.org.za/person/mosebenzi-joseph-zwane/ - no Register of Interests
https://www.pa.org.za/person/eddie-makue/ - no Appearances or Register of Interests

I am busy doing a quality check and if this is something that has to be fixed per profile, let me know and I can plan my checks and send a group rather than one by one.

Looking at the code it appears that the tabs are only shown when there is a register of interests or some appearances. So the question is do we want to just always show these tabs and then have a page that says "No appearances" (or whatever). This might make it clearer and more consistent for the user.

[chrismytton]

This is the relevant bit of code

pombola/pombola/south_africa/templates/core/person_detail.html

Lines 113 to 122 in fe2e374

	{% if object.interests_register_entries.exists %}
	<li class="ui-state-default">
	<a class="ui-tabs-anchor" href="#membersinterests">Register of Interests</a>
	</li>
	{% endif %}
	{% if hansard.count or question.count or committee.count %}
	<li class="ui-state-default">
	<a class="ui-tabs-anchor" href="#appearances">Appearances</a>
	</li>
	{% endif %}

[chrismytton]

Looks to me like the tabs are only appearing when they're supposed to, which is contrary to what Megan thought. Have emailed her to ask for clarification.

[chrismytton]

Response from Megan:

Did a search on PMG and these are all Makue’s appearances - https://pmg.org.za/search/?filter%5Btype%5D=committee_meeting&q=Makue

So it looks like there are committee and Hansard appearances for him, but they're not showing up on pa.org.za for some reason.

I wonder if this is related to #2458? It seems that something in za-hansard isn't matching things properly somewhere along the chain.

[chrismytton]

I think for Mosebenzi Joseph Zwane we genuinely don't have any register of interests for him. There's no mention of him in the pombola/south_africa/data/members-interests directory that I can see.

[chrismytton]

I think this issue is related to the missing plenary appearances #2458.