Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The pombola.settings package is too complex #2631

Open
chrismytton opened this issue Jun 12, 2019 · 0 comments
Open

The pombola.settings package is too complex #2631

chrismytton opened this issue Jun 12, 2019 · 0 comments

Comments

@chrismytton
Copy link
Member

At the moment there is a fair bit of complexity in the pombola.settings package (in the pombola/settings/ directory).

$ ls pombola/settings/
__init__.py           nigeria.py            tests.py
apps.py               nigeria_base.py       tests_base.py
base.py               no_country.py         tests_kenya.py
kenya.py              south_africa.py       tests_nigeria.py
kenya_base.py         south_africa_base.py  tests_south_africa.py

Some of these files are quite large, base.py is 647 lines! Of settings!

$ wc -l pombola/settings/*
       0 pombola/settings/__init__.py
      16 pombola/settings/apps.py
     647 pombola/settings/base.py
      14 pombola/settings/kenya.py
     102 pombola/settings/kenya_base.py
      13 pombola/settings/nigeria.py
      25 pombola/settings/nigeria_base.py
      12 pombola/settings/no_country.py
      45 pombola/settings/south_africa.py
     135 pombola/settings/south_africa_base.py
      23 pombola/settings/tests.py
      39 pombola/settings/tests_base.py
      14 pombola/settings/tests_kenya.py
      14 pombola/settings/tests_nigeria.py
      30 pombola/settings/tests_south_africa.py
    1129 total

When we move to country specific repos, #2630, then we can hopefully eliminate lots of this complexity and just have a one base settings file and one test settings file per repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant