Skip to content
This repository has been archived by the owner on Jan 25, 2019. It is now read-only.

Test FAIL: Check that apostrophes in words don't end up as ugly seperators #85

Open
garyvdm opened this issue Jul 3, 2012 · 1 comment

Comments

@garyvdm
Copy link
Contributor

garyvdm commented Jul 3, 2012

Running the test suite on that latest master, I get the following failure:

======================================================================
FAIL: Check that apostrophes in words don't end up as ugly seperators
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/garyvdm/wok.git/wok/tests/test_util.py", line 44, in test_apostrophes
    self.assertEqual(slug, util.slugify(orig))
AssertionError: u'dont-use-bobs-stuff' != u'don-t-use-bob-s-stuff'
- dont-use-bobs-stuff
+ don-t-use-bob-s-stuff
?    +         +
@mythmon
Copy link
Owner

mythmon commented Aug 12, 2012

(This isn't documented but should be). The tests are designed to be run with Twisted's trial, which makes use of a 'expected failure' modification for tests. That test is marked as expected to fail, since I never make sluggify do that, and at this point feel like it would break backwards compatibility.

Going forward one of a few things should happen

  1. Remove dependency on trial and implement expected failures differently.
  2. Fix the test, backwards compatibility be damned (This will probably happen in v1.0).
  3. Document the dependency on trial.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants