Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tempo2Pulsar is not units aware #371

Open
vhaasteren opened this issue Dec 14, 2023 · 0 comments
Open

Tempo2Pulsar is not units aware #371

vhaasteren opened this issue Dec 14, 2023 · 0 comments

Comments

@vhaasteren
Copy link
Member

Tempo2Pulsar does not know what units the parameters and the designmatrix have. If one just marginalizes over timing model parmaters, that is not important. But if one is interested in the timing model parameters, the design matrix and the timing model parameter units need to match. Moreover, the units need to be known for comparison with PINT or other values in the literature.

Supporting this will require working together with libstempo to support it there as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant