Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dlnf for the foreground single? #108

Open
YihaoZhou27 opened this issue Apr 16, 2024 · 0 comments
Open

Missing dlnf for the foreground single? #108

YihaoZhou27 opened this issue Apr 16, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@YihaoZhou27
Copy link

In the function _gws_harmonics_at_evo_fobs in gravwaves.py, it seems that the output foreground signal doesn't include the term "1/d lnf". (I assume the output strain is characteristic strain since the output background single includes the term of 1/d lnf)

Here is part of the code, the output loud is directly from the variabletemp, which is the GW strain I guess.

    # --- Calculate GW Signals
    temp = hs2 * gne * (2.0 / harms_1d)**2
    both = np.sum(temp[:, np.newaxis] * num_pois / dlnf, axis=0)

    # Calculate and return the expectation value hc^2 for each harmonic
    # (N, H)
    gwb_harms = np.zeros_like(harms_2d, dtype=float)
    gwb_harms[valid] = temp * num_binaries / dlnf
    # (N, H) ==> (H,)
    gwb_harms = np.sum(gwb_harms, axis=0)

    if np.any(num_pois > 0):
        # Find the L loudest binaries in each realizations
        loud = np.sort(temp[:, np.newaxis] * (num_pois > 0), axis=0)[::-1, :]
        fore = loud[0, :]
        loud = loud[:loudest, :]
    else:
        fore = np.zeros_like(both)
        loud = np.zeros((loudest, nreals))

    back = both - fore
    return both, fore, back, loud, gwb_harms
@YihaoZhou27 YihaoZhou27 changed the title missing dlnf for the foreground single when using the cosmological simulation? missing dlnf for the foreground single? Apr 16, 2024
@YihaoZhou27 YihaoZhou27 changed the title missing dlnf for the foreground single? Missing dlnf for the foreground single? Apr 16, 2024
@lzkelley lzkelley self-assigned this Apr 17, 2024
@lzkelley lzkelley added the bug Something isn't working label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants