-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue126 remove geospaas urls #153
base: master
Are you sure you want to change the base?
Conversation
@akorosov @aperrin66 I delete the whole nansat_ingestor app in b90668a because we have developed localharvester in the harvesting repo! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Removing
nansat_ingestor
should be in a different pull request. - There are still references to
geospaas.urls
in the repository
gg, created = GeographicLocation.objects.get_or_create(geometry=WKTReader().read(geom_wkt)) | ||
gg, created = GeographicLocation.objects.get_or_create(geometry=WKTReader().read(geom_wkt)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the error due to max precision does not happen anymore, this test can probably be deleted.
Or maybe it still happens with a particular database backend?
Even if it is the case, I am not sure if we should keep that test, since it does not validate a desired behavior.
Maybe it would be more relevant to create an issue about this problem, describing steps to reproduce it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't seen this error myself. However the test can remain here.
What's needed:
- rename the test to reflect that
not_null_constraint_failed
is not reproduced anymore - add a relevant comment that db actually can handle high precision numbers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in 04899cf
@aperrin66 ok! by the last four commits I dont do anything regarding nansat_ingestor here. I will do it in another PR. |
which references do you mean @aperrin66 ? |
in geospaas.rst file? |
Among others, you can just look for the "geospaas.urls" string in django-geo-spaas to find them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor correction to the test__reproduce__not_null_constraint_failed()
test
removing geospaas.urls.py as mentioned in #126