Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests use the incorrect data type for HK testing #8

Open
mbenson1 opened this issue Jun 19, 2020 · 1 comment
Open

Unit tests use the incorrect data type for HK testing #8

mbenson1 opened this issue Jun 19, 2020 · 1 comment

Comments

@mbenson1
Copy link

mbenson1 commented Jun 19, 2020

The SCH_HousekeepingCmd_Test() function in the sch_cmds_test.c file sets:

SCH_AppData.IgnoreMajorFrame = 19;
SCH_AppData.UnexpectedMajorFrame = 20;

But both variables are data type "boolean". This still compiles and passed with older versions of the OSAL, but with OSAL 6.7.3-bv this compiles but fails unit test. I recommend changing the 19 and 20 to true. When this change is made, SCH passes unit testing.

@ejtimmon
Copy link
Contributor

I've added this to our internal issue tracker. This will be addressed in the next release of SCH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants