Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a GET /restrictions endpoint for Operator #29

Open
punamverma opened this issue May 29, 2018 · 16 comments
Open

Create a GET /restrictions endpoint for Operator #29

punamverma opened this issue May 29, 2018 · 16 comments
Assignees

Comments

@punamverma
Copy link
Contributor

Operator should be able to query a restriction by constraint id.

@punamverma punamverma changed the title Create a GET Operator Endpoint for restrictions Create a GET /restrictions endpoint for Operator May 29, 2018
@nasajoey
Copy link
Member

nasajoey commented Jun 6, 2018

so this is for the NUSS client side API, not the USS spec. Does that sound right?

@punamverma
Copy link
Contributor Author

punamverma commented Jun 6, 2018

Yes, this issue was created for operator to be able to GET the constraints from a USS. Priya mentioned CONSTRAINT_MANAGER will also need to GET the constraints that it PUTs. Not sure if they need to be separate endpoints for an operator and for CONSTRAINT_MANAGER.

@nasajoey
Copy link
Member

OK, back on this one. Will try to address tomorrow morning.

nasajoey added a commit that referenced this issue Jun 19, 2018
There is an error referencing the domain.  Will need help resolving:

Error resolving $ref pointer "https://raw.githubusercontent.com/nasa/utm-apis/v4-draft/utm-domains/utm-domain-geojson.yaml#/definitions/ConstraintMessage". Token "ConstraintMessage" does not exist.
@nasajoey
Copy link
Member

OK, @punamverma please take a look at this commit. Is this a reasonable approach? Just copied the old manager_constraint endpoints and updated to point to correct model and renamed. There is a swagger problem pointing to an external domain, so I need help with that. I think you know how to fix that?

Error resolving $ref pointer "https://raw.githubusercontent.com/nasa/utm-apis/v4-draft/utm-domains/utm-domain-geojson.yaml#/definitions/ConstraintMessage". Token "ConstraintMessage" does not exist.

@punamverma
Copy link
Contributor Author

@nasajoey The Constraint message is under utm-domain-commons.yaml

https://raw.githubusercontent.com/nasa/utm-apis/v4-draft/utm-domains/utm-domain-commons.yaml#/definitions/ConstraintMessage

I guess thats what you wanted to be resolved. Pleas let me know. Thanks

@punamverma
Copy link
Contributor Author

@nasajoey I committed the correct link for ConstraintMessage.
However, I was wondering if we need a POST /restrictions for operator. I think he just needs to GET. For PUT we have an endpoint for Constraint Manager in Public Safety spec.

@nasajoey
Copy link
Member

@punamverma is this still a question? I don't think operator will be POSTing restrictions, unless I am misunderstanding need/use case.

@punamverma
Copy link
Contributor Author

punamverma commented Jul 17, 2018

Hi @nasajoey ,
Along with GET /restrictions endpoint, you have added POST and PUT endpoints too, which are not needed for an Operator. However, Operator only needs GET /restrictions endpoint. Hence, I was asking if that was intentional, or do you wan too remove it.
Thanks

nasajoey added a commit that referenced this issue Sep 1, 2018
Operator not POSTing restrictions... unneeded endpoint.
@nasajoey
Copy link
Member

nasajoey commented Sep 1, 2018

@punamverma please see if that last commit finalizes this or not.

@nasajoey
Copy link
Member

@punamverma pinging again. would like to close out. @issmith1 or @myspri may also take a look so we can close this.

@issmith1 issmith1 assigned shankar-iyer-96 and unassigned nasajoey Sep 27, 2018
@issmith1
Copy link
Member

Assignee (currently Shankar) ensure there is, or create a test for this endpoint. Postman (see Ops Lifecycle test) is a reasonable impl, then close out.

@myspri may want to create JIRA to manage this in our sprint.

@myspri
Copy link
Contributor

myspri commented Sep 27, 2018

@nasajoey @punamverma there are two pieces to this, both of which do not need changes to uss-api.

  1. This could be an NUSS operator api that allows operators to ask USS about known UVR (a.k.a) DR
  2. be a part of public safety api, that allows someone like FIMS to ask for constraints that were issued by this specific USS.

@punamverma you might want to consider moving this issue under public-safety.

@punamverma
Copy link
Contributor Author

@nasajoey @myspri We can close it, as this issue was for operator. And, I see a GET /restrictions for operator.
And , open a new one for the one @myspri mentioned - "be a part of public safety api, that allows someone like FIMS to ask for constraints that were issued by this specific USS."
Thanks.

@issmith1
Copy link
Member

But does the operator-api's /restrictions endpoint have at least 2 tests? (Pos and Neg)

@punamverma
Copy link
Contributor Author

No @issmith1 ..its not implemented yet.

@issmith1
Copy link
Member

note Dynamic Restrictions is now renamed to UAS Volume Reservation (UVR).
We can consider the priority of renaming this endpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants