Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and re-enable commented tests #157

Closed
notdanilo opened this issue Jan 15, 2021 · 0 comments · Fixed by #199
Closed

Fix and re-enable commented tests #157

notdanilo opened this issue Jan 15, 2021 · 0 comments · Fixed by #199
Labels
Type: Bug Something isn't working

Comments

@notdanilo
Copy link
Contributor

notdanilo commented Jan 15, 2021 •
edited
Loading

The following tests were disabled because they aren't passing and they are blocking unrelated PRs. They were already broken when the CI was enabled and they should be fixed to keep the test coverage as expected.

    nash::account::cancel_all_orders
    nash::account::cancel_order
    nash::account::limit_buy
    nash::account::limit_buy_fok
    nash::account::limit_buy_ioc
    nash::account::limit_sell
    nash::account::market_buy
    nash::account::market_sell

For more info check: https://github.com/nash-io/openlimits/pull/152/checks?check_run_id=1710957680
@notdanilo notdanilo added the Type: Bug Something isn't working label Jan 15, 2021
@notdanilo notdanilo linked a pull request Nov 11, 2021 that will close this issue
Exchange impl #199
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exchange impl nash-io/openlimits
1 participant
@notdanilo