Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Touch input does not cancel ongoing animations #86

Open
markusressel opened this issue Feb 9, 2019 · 2 comments
Open

Touch input does not cancel ongoing animations #86

markusressel opened this issue Feb 9, 2019 · 2 comments
Labels
is:bug

Comments

@markusressel
Copy link
Collaborator

When an animation is in progress from fling or moveTo and similar API methods the animation can not be canceled by the user touching the screen. It will stop however when touching the screen and dragging a minimal distance.

This issue was also partly discussed in #85.
@markusressel markusressel mentioned this issue Feb 9, 2019
Merged
@natario1
Copy link
Owner

natario1 commented Feb 9, 2019

Is #85 ready? It looks good to me. Just added a couple of comments.

Why do you think it stops when dragging a minimal distance - what triggers the stop in our code?

@natario1
Copy link
Owner

natario1 commented Feb 9, 2019

(As I just wrote there about boolean flags, I think this should be configurable.

As a developer, I might launch an animateTo() and NEED the engine to go there, without worrying about user finger going around.)

@markusressel markusressel mentioned this issue Jun 12, 2020
Merged
markusressel added a commit that referenced this issue Jun 13, 2020
@markusressel
Bugfix/#86 cancel fling with touch (#159)
f47d9a6 
* call cancelFling when the user touches the screen
refactored correctOverpan into method

* check whether a overpan correction was necessary or not (fix)

* revert unnecessary changes

* added onLongClickListener to ColorGridView

* disable longClick detection while we are flinging

* explicitly cancel fling when cancelling animations
@markusressel markusressel changed the title Touch input does not cancel fling or other ongoing animations Touch input does not cancel ongoing animations Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
is:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markusressel @natario1