Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron build breaks if invest --version produces extra stdout #1605

Open
emlys opened this issue Jul 31, 2024 · 0 comments
Open

electron build breaks if invest --version produces extra stdout #1605

emlys opened this issue Jul 31, 2024 · 0 comments
Labels
good first issue Good for new members of the software team task Something needs to be done

Comments

@emlys
Copy link
Member

emlys commented Jul 31, 2024

The workbench build with electron-builder runs the invest --version command to get the version string used later in the build:

const investVersion = execFileSync(
'../dist/invest/invest', ['--version']
).toString().trim();

If the command writes anything extra to stdout, the version string is invalid and the build fails. This is happening right now - I haven't identified the root cause yet, but swig/python detected a memory leak of type 'OSRSpatialReferenceShadow *', no destructor found. is being printed after the version. I recall the same issue happening once before. While this bug should be fixed, it doesn't need to break the electron build process.

Improve how we extract the version string to reduce chances of it being corrupted like this - maybe sufficient to just use the first line of output?

@emlys emlys added good first issue Good for new members of the software team task Something needs to be done labels Jul 31, 2024
@davemfish davemfish changed the title electron build breaks if invest list produces extra stdout electron build breaks if invest --version produces extra stdout Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for new members of the software team task Something needs to be done
Projects
None yet
Development

No branches or pull requests

1 participant