Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: Describe reviewer workflow #53

Open
stevegt opened this issue Apr 12, 2017 · 2 comments
Open

README: Describe reviewer workflow #53

stevegt opened this issue Apr 12, 2017 · 2 comments
Assignees
@stevegt

Comments

@stevegt
Copy link
Contributor

stevegt commented Apr 12, 2017 •
edited
Loading

Add a section to the README, walking reviewers through how to set up a personal fork of the repo and review/accept PRs, probably something like:

Setup

  1. fork repo
  2. set github pages config so fork is viewable at https://username.github.io/nationofmakers.github.io/

Review/Publish PR

  1. pull PR branch to local, push to fork
  2. test, edit if needed
  3. push any edits back to upstream PR branch
  4. if no new edits were needed, merge PR to upstream master -- this will cause github to publish it on the public site
  5. if new edits were needed, get someone else to review/merge (can be original submitter if they have merge auth)
@mkenigson
Copy link

mkenigson commented Apr 13, 2017 •
edited
Loading

Is this the "dug up, restored, and updated" language described in #52 ?

@stevegt
Copy link
Contributor Author

stevegt commented Apr 13, 2017

No, this would be a new section in the README. Also see comment I'm adding right now in #52.

@stevegt stevegt self-assigned this May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevegt stevegt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stevegt @mkenigson