Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make email link open new window/tab #55

Closed
mkenigson opened this issue Apr 13, 2017 · 5 comments
Closed

Make email link open new window/tab #55

mkenigson opened this issue Apr 13, 2017 · 5 comments

Comments

@mkenigson
Copy link

Might want to set target="_blank" for the [email protected] email link.

@millracetheatre
Copy link
Contributor

millracetheatre commented Apr 13, 2017

Please don't do this. It would just open a new tab and it would confuse people.

In fairness [a href="mailto:[email protected]" class="btn btn-lg btn-primary"][email protected][/a] should be good, but the Bootstrap CSS is overriding its selectability.

I recommend we stick with [a href="mailto:[email protected]" ][email protected][/a] for now. It's not as flashy, but it's accessible.

-Tome

@stevegt
Copy link
Contributor

stevegt commented Apr 13, 2017

Tome, do you think you could unravel the CSS so we can close #54?

@danawoodman
Copy link
Member

I agree, mailto works even if it's less elegant. Once we have a contact form we can remove that.

@millracetheatre
Copy link
Contributor

millracetheatre commented Apr 14, 2017 via email

@stevegt
Copy link
Contributor

stevegt commented Apr 14, 2017

Consensus seems to go toward closing this; will do so if there are no objections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants