Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum values for Params #1

Open
kirbysayshi opened this issue Mar 24, 2019 · 0 comments
Open

Maximum values for Params #1

kirbysayshi opened this issue Mar 24, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@kirbysayshi
Copy link
Contributor

There is no definition of a max audio param value, which in the case of the stretch node could cause an out of memory condition. For example, set a stretch value of something very high, but still a valid number, such as 99999. The system will attempt to allocate a buffer large enough to accommodate, and likely crash.

This is not an issue if the Scores are controlled by the author, as it's basically the same risks as running untrusted JS.

But it would be nice to provide reasonable maximum values, and warn (console.warn?) the user of a possible error situation.

@kirbysayshi kirbysayshi added the enhancement New feature or request label Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant