Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo split #11

Open
kirbysayshi opened this issue Mar 25, 2019 · 1 comment
Open

Monorepo split #11

kirbysayshi opened this issue Mar 25, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@kirbysayshi
Copy link
Contributor

kirbysayshi commented Mar 25, 2019

There are a few existing components that make sense as standalone packages:

  • demo app (/demo)
  • Monaco editor with NFPlayer+NFGrapher hinting (it severely slows down the build time and dev time feedback loop since it's megabytes of JS. Also requires expanding memory limits at compile times due to how large the source maps are!) (it's also kind of hard to separate out, since it compiles to separate scripts that must be loaded into a web worker, and thus must be reachable by whatever the final consuming process is)
  • Player (current root)
  • CLI (src/cli.ts): would be nice to keep CLI dependencies away from actual Player dependencies.
  • TimeInstant (maybe useful if you are consuming NFGrapher without the player?)
  • future MusicalMath (time and interval calculations based on musical concepts like beats, bars, tempo, keys, pitches)

It could also just greatly complicate infrastructure for little gain. Probable approach https://medium.com/@jsilvax/a-workflow-guide-for-lerna-with-yarn-workspaces-60f97481149d

@kirbysayshi kirbysayshi added the enhancement New feature or request label Mar 25, 2019
@hydrosquall
Copy link
Contributor

The one open source monorepo in the wild that I've seen seemingly happily using Lerna for a while is nteract (https://github.com/nteract/nteract), in case you end up wanting another outside example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants