Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the getRobotVelocity function #187

Open
q576333 opened this issue Apr 23, 2020 · 2 comments
Open

Implement the getRobotVelocity function #187

q576333 opened this issue Apr 23, 2020 · 2 comments

Comments

@q576333
Copy link

q576333 commented Apr 23, 2020

Hi everyone
Now, I try to implement my own local planner, so I need the actual robot velocity feedback. Therefore I try to contribute getRobotVelocity function in RobotInformation class. But I see the highlight in this function comment is "TODO implement and filter tf data to compute velocity.". What's the meaning in this sentence: "filter tf data to compute velocity"? Does it mean using the amount of change in two consecutive pose(from map to base_link) to find the robot speed?
Why not direct subscribe the /odom topic to get velocity feedback?

@q576333
Copy link
Author

q576333 commented Apr 24, 2020

I have already prepared PR.
In addition, I have confused why we need two getRobotPose function? One in the RobotInformation class, another in the mbf_utility namespace. I think getRobotVelocity function encounters the same situation.

@corot
Copy link
Collaborator

corot commented Apr 24, 2020

I think yes, that's what the TODO means. But Subscribing to odom is a better option, for sure. I would do this way.

As for getRobotPose. the one in RobotInformation is a wrapper for the one in mbf_utility. Probably you should use the one in RobotInformation (actually there's A THIRD version on AbstractNavigationServer but I'll remove it).

Btw, if you and implement getRobotVelocity method to get the velocity from odom topic, the second parameter look_back_duration doesn't make sense; feel free to remove it

@spuetz , thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants