Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grouped_adjacency: improve grouping error checks and docs #22

Open
jefferis opened this issue Jul 10, 2020 · 1 comment
Open

grouped_adjacency: improve grouping error checks and docs #22

jefferis opened this issue Jul 10, 2020 · 1 comment

Comments

@jefferis
Copy link
Contributor

right now if you specify ingroup or outgroup as

  • a character vector containing types, grouped_adjacency just tried to match against neuprint columns type, name, cellBodyFiber
  • a factor without names, it just passes straight through the check logic

We should probably give a warning when ingroup is unnamed and an error if it is unnamed and the wrong length.

If we were being keen, we would also support a two column dataframe in which one column is the bodyid (interpreted by neuprint_ids) and the other column is the grouping variable. This would save reorganising things ...
@jefferis
Copy link
Contributor Author

Should support all of the options mentioned above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jefferis