Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign Git Queue commits #30

Open
josecelano opened this issue Mar 4, 2022 · 4 comments · Fixed by #31 or #32
Open

Sign Git Queue commits #30

josecelano opened this issue Mar 4, 2022 · 4 comments · Fixed by #31 or #32
Labels
enhancement New feature or request

Comments

@josecelano
Copy link
Member

josecelano commented Mar 4, 2022

Commits created by the Git Queue action are not being signed.

image

That's because by default the git queue does not sign the commits.

@da2ce7 proposed to sign them at the end of the workflow with a commit amend.

It can be done with a rebase: https://superuser.com/a/1123928/277693

Until we implement that final solution we just can enable signing when using the git-queue action:

- name: Create new job
  id: create-job
  if: ${{ steps.get-next-job.outputs.job_found == 'false' && steps.update-submodule.outputs.updated == 'true' }}
  uses: Nautilus-Cyberneering/git-queue@v1-beta
  with:
    queue_name: "library-update"
    action: "create-job"
    job_payload: "${{ steps.build-payload.outputs.payload }}"
    git_commit_gpg_sign: "true"

We have to do it with all steps using the action.

@josecelano josecelano added the enhancement New feature or request label Mar 4, 2022
josecelano added a commit that referenced this issue Mar 4, 2022
@josecelano josecelano linked a pull request Mar 4, 2022 that will close this issue
@josecelano
Copy link
Member Author

josecelano commented Mar 4, 2022

It seems that is not working only by enabling the input: git_commit_gpg_sign: "true"

@josecelano josecelano reopened this Mar 4, 2022
@josecelano josecelano linked a pull request Mar 4, 2022 that will close this issue
josecelano added a commit that referenced this issue Mar 4, 2022
…ueue-commits

Fix: [#30] wrong input to enable signing commits
@josecelano
Copy link
Member Author

It seems that is not working only by enabling the input: git_commit_gpg_sign: "true"

Fixed. We have signed commits using git-queue:

image

I'm going to reopen the issue to implement the definitive solution: signing after committing.

@josecelano josecelano reopened this Mar 4, 2022
@da2ce7
Copy link

da2ce7 commented Mar 4, 2022

Related: nautilus-cyberneering/git-queue#31

@josecelano
Copy link
Member Author

Related: Nautilus-Cyberneering/git-queue#31

@da2ce7 I think it's more related to this one: nautilus-cyberneering/git-queue#22

The author, as far as I know, it's not related to the GPG signing key. It's the "committer".

josecelano added a commit that referenced this issue Jun 13, 2022
josecelano added a commit that referenced this issue Jun 13, 2022
…ueue-commits

Fix: [#30] wrong input to enable signing commits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants