Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create action to check valid commit subjects #83

Open
2 tasks
josecelano opened this issue Mar 7, 2022 · 0 comments
Open
2 tasks

Create action to check valid commit subjects #83

josecelano opened this issue Mar 7, 2022 · 0 comments

Comments

@josecelano
Copy link
Member

josecelano commented Mar 7, 2022

@da2ce7 proposed to create a workflow that forbids other commits to start with the same prefix as the queue.

We use the first Character to Identify the Queue Commits. Maybe we should then remove the "📝" character. Then we should have a workflow that forbids any other commit to start with the "🈺", "⬆️" and "⬇️" emojis.

Originally posted by @da2ce7 in #21 (comment)

  • Create an action that validates the commit subject. It should make the workflow fail when there is a commit with one of these emojis: "🈺", "⬆️" and "⬇️".
  • Add the workflow to the sample projects: library-consumer, chinese-ideaographs-website.

NOTES:

  • We have to check if the first character is a queue prefix but we also have to check that is not a legitimate queue subject. Maybe we can check if the first character is the emoji but the second is not the queue delimiter.
  • We should check all the new commits that are going to be added to the target branch.

@da2ce7 was that your idea?

@josecelano josecelano mentioned this issue Mar 7, 2022
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant