Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom domains to PR environments #738

Open
lorenyu opened this issue Aug 16, 2024 · 0 comments
Open

Add custom domains to PR environments #738

lorenyu opened this issue Aug 16, 2024 · 0 comments
Labels
scope: service Service layer / component type: feature New feature or new functionality to existing feature workflow: good first issue Good for newcomers

Comments

@lorenyu
Copy link
Contributor

lorenyu commented Aug 16, 2024 •
edited
Loading

PR environments are currently accessed via the load balancer endpoint, but there's nothing stopping us from giving PR environments custom domains too. They can be a subdomain of the dev environment domain e.g. p-131.platform-test-dev.navateam.com
@lorenyu lorenyu added type: feature New feature or new functionality to existing feature scope: service Service layer / component workflow: good first issue Good for newcomers labels Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope: service Service layer / component type: feature New feature or new functionality to existing feature workflow: good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lorenyu