Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Historikkvask skal kunne rydde i rekkefølgefeil fra k9-sak når det er… #1908

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

boerta
Copy link
Contributor

@boerta boerta commented Feb 14, 2024

… korrigert i historikktabell

@boerta boerta requested a review from baskevold February 14, 2024 15:01
@boerta
Copy link
Contributor Author

boerta commented Feb 14, 2024

Noen tester feiler fortsatt. Fikser i morgen

@@ -91,16 +91,11 @@ class OppgaveV3Repository(
select *
from oppgave_v3 ov
where ekstern_id = :eksternId
and versjon = (
select versjon - 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tipper dette er årsaken til at vaskeevent-testene feiler. Tester som sender flere eventer vil vel forsøke å hente sin egen versjon, som ikke eksisterer enda

where ekstern_id = :eksternId
and ekstern_versjon = :eksternVersjon
and intern_versjon = :internVersjon
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skulle vært versjon?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ja, det boblet opp en del syntax error greier i sqlene når jeg løste den andre feilen :) kommer fiks straks

@boerta boerta marked this pull request as ready for review February 19, 2024 14:10
@boerta boerta requested a review from a team as a code owner February 19, 2024 14:10
@boerta boerta merged commit 62808dd into master Feb 20, 2024
1 check passed
@boerta boerta deleted the bugfix/historikkvask_rekkefølge branch February 20, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants