Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Publication" and "Publication Manifest" under "Choose a Metadata Template Type:" #214

Closed
aclayton555 opened this issue May 8, 2023 · 8 comments
Assignees

Comments

@aclayton555
Copy link
Contributor

When playing around with the Publication schema, I noted that the HTAN DCA includes both "Publication" and "Publication Manifest" in the dropdown under "Choose a Metadata Template Type"
Screen Shot 2023-05-08 at 10 39 09 AM

I seem to get a disconnect if selecting "Publication." "Publication Manifest" seems to work though and appears to be the latest version of the schema.

Is there a way to tidy this up so that contributors only see the correct "Publication Manifest."


How important is this feature?

  • 🌗 Medium - can do work without it; but it's important (e.g. to save time or for convenience)

When will use cases depending on this become relevant?

  • Short-term - 2-4 weeks
@adamjtaylor
Copy link
Contributor

adamjtaylor commented May 9, 2023

I think this is due to how the config is being generated on deployment (which now happens in a script).
It seems to pick up top-level parents to be included as templates.

I also see the following in the template list that should not be there

  • File
  • Patient
  • Publication

We will need a FAIR ticket to ask how to hide these.

@aclayton555
Copy link
Contributor Author

@MiekoHash @milen-sage Can we file an issue in FSD for someone on FAIR to look at this?

@MiekoHash
Copy link

Thanks for asking, @aclayton555 . Sure, pls go ahead and file a JIRA ticket in FSD space. We will push it through the triage process.

@aclayton555
Copy link
Contributor Author

@MiekoHash FDS ticket filed here: https://sagebionetworks.jira.com/browse/FDS-408

Thanks!

@aclayton555 aclayton555 self-assigned this May 9, 2023
@aclayton555
Copy link
Contributor Author

See Jira issue for diagnosis and suggested fix for the HTAN team: https://sagebionetworks.jira.com/browse/FDS-408

Transitioning this to "ready for development." Ideal to tackle in this sprint to resolve this before we focus efforts on multi-tenant DCA testing in June.

@adamjtaylor
Copy link
Contributor

@elv-sb and I have reviewed the proposed fix and have agreed we do not want to do anything regarding changing the deploy action or the config while we are only a short time away from multitenant deployment.

@adamjtaylor
Copy link
Contributor

For 2023-06-28 sprint wrap-up, I think we can move this either to the backlog or to not planned. Consider adding a label multitenant to track issues with this transfer.

@aclayton555
Copy link
Contributor Author

i'm inclined to put this back in the backlog, and have proceeded to add a "multitenantDCA" label for us to come back to this in an upcoming sprint (regardless of whether it is decided to do/not do work on this) once the multitenant rolls out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants