Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concurrancy to Github CI action #224

Closed
adamjtaylor opened this issue May 17, 2023 · 2 comments · Fixed by #252
Closed

Add concurrancy to Github CI action #224

adamjtaylor opened this issue May 17, 2023 · 2 comments · Fixed by #252
Assignees
Labels
effort-mid This one needs your brain

Comments

@adamjtaylor
Copy link
Contributor

Currently, the lint, validate and convert action runs when a commit is made into a PR. If two commits are made in close sequence then two actions can be launched, when only the latter needs to complete.

This can cause the second action to fail in the commit phase of the conversion job as it seems that there are unstashed changes from when the first job overwrote the JSON-LD.

We can use GitHub actions concurrency to cancel previously started jobs to ensure that this does not occur

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#concurrency

@adamjtaylor
Copy link
Contributor Author

We are seeing concurrency issues in #245, so we should prioritize this for the July sprint

@aclayton555 aclayton555 added the effort-mid This one needs your brain label Jun 28, 2023
@adamjtaylor
Copy link
Contributor Author

@adamjtaylor adamjtaylor linked a pull request Jul 10, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort-mid This one needs your brain
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants