Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel Metadata Antibody Role Valid Value #431

Closed
4 of 9 tasks
PozhidayevaDarya opened this issue Jun 26, 2024 · 2 comments · Fixed by #432
Closed
4 of 9 tasks

Channel Metadata Antibody Role Valid Value #431

PozhidayevaDarya opened this issue Jun 26, 2024 · 2 comments · Fixed by #432
Assignees
Labels

Comments

@PozhidayevaDarya
Copy link
Contributor

PozhidayevaDarya commented Jun 26, 2024

Information

In the submission of GeoMx Channel Metadata, the submitter reached out with a request:

Antibody Role (col G): “secondary antibody” is inaccurate: Syto13 is not an antibody at all. It is a cell-permeant dye/stain that exhibits enhanced green fluorescence when bound to nucleic acid. Not sure how to fix col G; neither option given is valid:

Possible to leave it blank (ie. make it not required)
Or better add “N/A” as an option
Out or reach I know, ideally this header would be more useful if more flexible and it was called “Molecular Probe Type” (then options could be primary antibody, secondary antibody, dye/stain..).

RRID Identifier (col J): Syto13 is not an antibody and the RRID ID doesn’t seem to include non-antibody molecular probes. ”AB _0000000” – would be fine in combination with I and K edits as noted.

Screenshot 2024-06-26 at 9 25 21 AM

Proposed change:

Add an additional valid value to the Antibody Role Attribute - "Neither - Dye/Stain"
Add "Not Applicable" as valid value to RRID Identifier Attribute


Additional context

PR is linked here: #432

Implementation checklist

  • Branch created
  • HTAN.model.csv editied and pushed
  • HTAN.model.jsonld validated and created by Github action
  • PR opened
  • PR approved
  • PR merged into main
  • New Component added to ncihtan/HTAN-data-curator (if required)
  • DCA update requested
  • DCA updated
@aclayton555
Copy link
Contributor

I see this was added mid-sprint. If possible, let's try to wrap this up as part of our 24-6 sprint, which ends 2024.06.28

@PozhidayevaDarya
Copy link
Contributor Author

@aclayton555 Thank you!

@adamjtaylor adamjtaylor linked a pull request Jun 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants