Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cDNA attribute from Multiplexed CITE-seq Level 1 #436

Closed
4 of 9 tasks
PozhidayevaDarya opened this issue Jun 28, 2024 · 2 comments · Fixed by #437
Closed
4 of 9 tasks

Remove cDNA attribute from Multiplexed CITE-seq Level 1 #436

PozhidayevaDarya opened this issue Jun 28, 2024 · 2 comments · Fixed by #437
Assignees
Labels

Comments

@PozhidayevaDarya
Copy link
Contributor

PozhidayevaDarya commented Jun 28, 2024

Information

The cDNA attribute was mistakenly added into the DependsOn of Multiplexed CITE-seq Level 1

Proposed change:

Delete cDNA from DependsOn of Multiplexed CITE-seq Level 1 (already captured in Read1 and 2)


Dicussion link:

Linked to the following PR: #437

Implementation checklist

  • Branch created
  • HTAN.model.csv editied and pushed
  • HTAN.model.jsonld validated and created by Github action
  • PR opened
  • PR approved
  • PR merged into main
  • New Component added to ncihtan/HTAN-data-curator (if required)
  • DCA update requested
  • DCA updated
@aclayton555
Copy link
Contributor

Is this similar to the cDNA attributes that were pulled in to the CDS template in #434

If so, do we want to fix that one now too?

@adamjtaylor adamjtaylor linked a pull request Jul 9, 2024 that will close this issue
@adamjtaylor
Copy link
Contributor

Yes lets fix as part of this issues and PR #437

PR #437 currently blocked as the JSON-LD won't generate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants