Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub actions to build conditional dependencies table for HTAN docs #442

Closed
aditigopalan opened this issue Jul 22, 2024 · 6 comments · Fixed by #441
Closed

Add GitHub actions to build conditional dependencies table for HTAN docs #442

aditigopalan opened this issue Jul 22, 2024 · 6 comments · Fixed by #441
Assignees
Labels

Comments

@aditigopalan
Copy link
Contributor

aditigopalan commented Jul 22, 2024

  1. Add conditional dependencies file to the data model
  2. Set up a GitHub Actions workflow that triggers on a new data model release, interacts with the specified endpoint to generate an attribute table, and then opens a PR to merge the results.
@aditigopalan
Copy link
Contributor Author

Ready for review!

@aclayton555
Copy link
Contributor

24-7 close out: With the PR merged, @adamjtaylor please feel free to close this out if appropriate

@aditigopalan
Copy link
Contributor Author

@aclayton555 @adamjtaylor PR #441 is still open, which is why I think this issue is ongoing into the next sprint

@aclayton555
Copy link
Contributor

aclayton555 commented Aug 13, 2024

@adamjtaylor to review PR. Want to ensure we test actions.

Upon testing, failure due to 128. Failure in "Fetch latest changes" pulling from main. Adam thinks we can remove this step. @aditigopalan to dig into this and ping team for additional testing. Not expecting this to break anything, but want to make sure this is running okay.

Ensure any actions are updated accordingly with appropriate version numbers

@aditigopalan
Copy link
Contributor Author

Update: The action is still failing, which is surprising since the fetch operation works fine locally but fails on GitHub Actions with the following error:

Traceback (most recent call last):
File "", line 15, in
File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/requests/models.py", line 1024, in raise_for_status
raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 405 Client Error: METHOD NOT ALLOWED for url: https://schematic.api.sagebionetworks.org/v1/ui/

I've reached out to Lingling to verify if the API endpoint and the HTTP method being used are correct.

@aditigopalan aditigopalan reopened this Sep 10, 2024
@aditigopalan
Copy link
Contributor Author

Fixed, the issue was having two actions running simultaneously

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants