Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renewal -- update data model attributes and descriptions to disambiguate index/days to fields #444

Open
9 tasks
jen-dfci opened this issue Jul 29, 2024 · 2 comments
Labels

Comments

@jen-dfci
Copy link

Information

Many attributes use the term "index" or are days to/from fields but are ambiguous or deviate from index being date of birth.

Proposed change:

  1. Review attributes and descriptions with issues.
  2. Check values received for these attributes to determine is data is not as expected.
  3. Look at CDC/CRDC fields and try to align.
  4. update attribute names and descriptions as needed.**
    ** These may be breaking changes

Dicussion link:

Link to where the changes have been discussed/approved eg Closed RFC, Service desk ticket, DCC coordination/operations agenda


How important is this feature?

Select from the options below

  • 🌗 Medium - can do work without it; but it's important (e.g. to save time or for convenience)

When will use cases depending on this become relevant?

  • Mid-term - 2-4 months

Issues are arising now. Would like to fix prior to phase 2 data submissions.


Additional context

Add any other context or screenshots about the feature request here

Implementation checklist

  • Branch created
  • HTAN.model.csv editied and pushed
  • HTAN.model.jsonld validated and created by Github action
  • PR opened
  • PR approved
  • PR merged into main
  • New Component added to ncihtan/HTAN-data-curator (if required)
  • DCA update requested
  • DCA updated
@jen-dfci jen-dfci changed the title update data model attributes and descriptions to disambiguate index/days to fields renewal -- update data model attributes and descriptions to disambiguate index/days to fields Aug 1, 2024
@jen-dfci
Copy link
Author

jen-dfci commented Aug 1, 2024

@jen-dfci
Copy link
Author

Final recommendation is to update descriptions in the data model only. (Do not change attribute names.). Description changes are in column R in the spreadsheet: https://docs.google.com/spreadsheets/d/1gPBsS-fS-BVA4LNfFgzm2rsHN5ACjZ2mfOPZB1nBJ-o/edit?usp=drive_link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants