Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDB file #1

Open
823639792 opened this issue Aug 13, 2020 · 0 comments
Open

PDB file #1

823639792 opened this issue Aug 13, 2020 · 0 comments

Comments

@823639792
Copy link

I can't find PDB files in windows.
So I want to compile v8, can you give me zhe gn args?
crocuis pushed a commit that referenced this issue May 17, 2022
@LeszekSwirski
Version 9.7.106.6 (cherry-pick)
ce376c3 
Merged 85ab0ad7789a7188b4c0b2be3cd3d758134c7de6

Reland "[runtime] Reset clobbered argument in DefineClass"

[email protected]

Change-Id: Ie507ca7fd74a60a3233f046a4def2156013111ee
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289179
Reviewed-by: Igor Sheludko <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.7@{#10}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
@paolosevMSFT
Merged: [wasm][turbofan] Disable inlining of JS->Wasm calls by default
be83571 
(cherry picked from commit 9c8741567d29c09133f305e521c076a0b7205d8a)

Change-Id: Id3bece7b5b119397c41ff3d714cdbeb26f37f965
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Bug: chromium:1271456
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289181
Reviewed-by: Andreas Haas <[email protected]>
Commit-Queue: Clemens Backes <[email protected]>
Commit-Queue: Andreas Haas <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.7@{#11}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
Whitespace to trigger builders
82ce475 
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Change-Id: I9de26b1e86783768fc41ec704e1f5b24aabd3cda
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289182
Reviewed-by: Michael Achenbach <[email protected]>
Commit-Queue: Liviu Rau <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.7@{#12}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
Revert "Whitespace to trigger builders"
49aae8b 
This reverts commit 82ce475.

Reason for revert: trigger builders

Original change's description:
> Whitespace to trigger builders
>
> No-Try: true
> No-Presubmit: true
> No-Tree-Checks: true
> Change-Id: I9de26b1e86783768fc41ec704e1f5b24aabd3cda
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289182
> Reviewed-by: Michael Achenbach <[email protected]>
> Commit-Queue: Liviu Rau <[email protected]>
> Cr-Commit-Position: refs/branch-heads/9.7@{#12}
> Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
> Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}

Change-Id: I31afa1623dbf70835312cd87b8897d6416a204c8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3293087
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Liviu Rau <[email protected]>
Reviewed-by: Michael Achenbach <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.7@{#13}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
@mi-ac
Version 9.7.106.7
31efda6 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I38bd3ba0e3d771a7f4eb21cb5999e1f71a12a36a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3288242
Reviewed-by: Liviu Rau <[email protected]>
Commit-Queue: Liviu Rau <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.7@{#14}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
Merged: Squashed multiple commits.
5f980ae 
Merged: ppc: Don't emit cnttzd, cnttzw if Power proc. version is less than 9
Revision: 937d44e9ec11eb28a076ed69f5daf296cb146b74

Merged: ppc: Don't emit unsupported isns on Power8 arch
Revision: 2b01c8286b734b54fd5e020024c1d67e075f1969

Merged: PPC: Optimize count of trailing zeros on P8 and below
Revision: 0bb4006648ea5de29f775970905d47b727e01688

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Bug: v8:12404
Change-Id: I18c693794d72236fc1010950b0d89aa626d969b9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289930
Reviewed-by: Junliang Yan <[email protected]>
Commit-Queue: Lutz Vahl <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.7@{#15}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
Version 9.7.106.8
f28f6c3 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Icc9c93a33d46fa977a3929f231321f57de41c1e2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3293199
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: Liviu Rau <[email protected]>
Commit-Queue: Liviu Rau <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.7@{#16}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
Whitespace to test auto-tag ng
2dd1cd8 
[email protected]

No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Change-Id: I5b6cc839d1ce97e21d0f0b3e96ef69ff0f75a835
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295746
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Zhi An Ng <[email protected]>
Commit-Queue: Liviu Rau <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.7@{#17}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
[9.7 merge] Adds counter for snapshot decompress time when creating c…
c49ac1c 
…ontext

BUG=chromium:1257321
TEST=none

(cherry picked from commit 581355befe330b0a440c089ca8672f7afddc387a)

Change-Id: I59f34e8b41ba08f5046754c13be8f1df6a335655
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3271389
Reviewed-by: Jakob Gruber <[email protected]>
Reviewed-by: Michael Lippautz <[email protected]>
Commit-Queue: Scott Violet <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#77824}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295927
Cr-Commit-Position: refs/branch-heads/9.7@{#18}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
Version 9.7.106.9
bbd79ee 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I0682d6c0f7cc3929c0e7f63cdc318ed39c6ac0e9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3298209
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: Liviu Rau <[email protected]>
Owners-Override: Liviu Rau <[email protected]>
Commit-Queue: Liviu Rau <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.7@{#19}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
Whitespace to trigger builders
340fa4c 
[email protected]

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Ic5a6bbabb0bd594bac978efa1f8efd1dd929b9c5
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3303795
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Michael Achenbach <[email protected]>
Commit-Queue: Liviu Rau <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.7@{#20}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
Version 9.7.106.10
f1e32c4 
Change-Id: I4d3eafa27e6ea7e2aaca51355123be27c34b190c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3303899
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.7@{#21}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
Merged: [owners] Includes infra team as tools owners
ce4cb0c 
Revision: 823c44d39752cff656519dbdda0c8188443be401

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Change-Id: If371e92e611cf65242e6aba7c916cb753dbc94d7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306378
Reviewed-by: Tamer Tas <[email protected]>
Reviewed-by: Michael Achenbach <[email protected]>
Commit-Queue: Liviu Rau <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.7@{#22}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
Version 9.7.106.11
6bea14d 
Change-Id: Ifda5834f07fcf39e4b8636740052794e1aa6aad2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306655
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.7@{#23}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
Whitespace to trigger builders
624a6a9 
[email protected]

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I3011b8f0d77eb7ee792ba0797540ab45de17c981
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3307052
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Liviu Rau <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.7@{#24}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
Version 9.7.106.12
ea435dc 
Change-Id: I0415c5be6a0c3566b7487422f3f3086c3f31499a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306656
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.7@{#25}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
Merged: Add check for class constructor to CallFunction
8664e54 
Raise an exception if CallFunction is invoked with a class constructor.
The check was initially removed in [1] but there are cases where we
could end in CallFunction with class constructors from optimized code.

[1] https://crrev.com/c/3186434

(cherry picked from commit 3e40f8f091c59db06ec31d90a5e334756a9294cf)

Bug: chromium:1271384
Change-Id: I0d700c4b1d117334c1c4c14719e24cd1f2c5e3a2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3291313
Commit-Queue: Patrick Thier <[email protected]>
Reviewed-by: Jakob Gruber <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#77967}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306484
Cr-Commit-Position: refs/branch-heads/9.7@{#26}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
Version 9.7.106.13
0702d4f 
Change-Id: If8155e7691c096ca032110bb54d582dad15425ad
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3307798
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.7@{#27}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
@hiroshige-g
Merged: Allow compiled module invalidation at WasmStreaming::Finish()
417dee4 
This CL adds `can_use_compiled_module` parameter to
WasmStreaming::Finish() that is used by Chromium
https://chromium-review.googlesource.com/c/chromium/src/+/3282643
to invalidate compiled module bytes after SetCompiledModuleBytes().

(cherry picked from commit b0c6dd86bd563672dba6256f482dc5e145f094ae)

Bug: chromium:1260939
Change-Id: I462df0e25fbc693f7e7114e6bcfe2a01dc60beba
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306787
Commit-Queue: Hiroshige Hayashizaki <[email protected]>
Reviewed-by: Andreas Haas <[email protected]>
Reviewed-by: Leszek Swirski <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.7@{#28}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
Version 9.7.106.14
9d410fa 
Change-Id: I3699b0e4b2572787a89433ce2f5928d2cbe62102
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3310424
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.7@{#29}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
@mi-ac
Merged: Remove --isolated from mb.py
f6aa5f4 
Revision: 55a26dc4f1ef2e708a321094f7bdaaf6c0b2d1b1

BUG=chromium:1271841
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Change-Id: I43dd4d4ab22f20e2a9c43becbd4196c65688aa56
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3312478
Reviewed-by: Liviu Rau <[email protected]>
Commit-Queue: Michael Achenbach <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.7@{#30}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
Version 9.7.106.15
28b2036 
Change-Id: I2791735dde5133836864c26a6f9d64789e142685
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3311128
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.7@{#31}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
@schuay
Merged: [regexp] Fix CharacterRange limits again again again
5707d38 
When emitting code, character ranges must only specify ranges which
the actual subject string (one- or two-byte) may contain.

This was not always the case, specifically for ranges with
`from <= kMaxUint8` and `to > kMaxUint8`.

The reason this is so tricky: 1. not all parts of the pipeline know
whether we are compiling for one- or two-byte subjects; 2. for
case-insensitive regexps, an out-of-bounds CharacterRange may have an
in-bounds case equivalent (e.g. /[Ÿ]/i also matches 'ÿ' == \u{ff}),
which only gets added somewhere in the middle of the pipeline.

Our current solution is to clamp immediately before code emission. We
also keep the existing handling/dchecks of the 0x10ffff marker value
which may occur in the two-byte subject case.

(cherry picked from commit 2e17aaca2a86903f1a90dae31c8c89fc60996df2)

No-Try: true
No-Presubmit: true
No-Treechecks: true
Bug: v8:11069
Change-Id: Ic7b34a13a900ea2aa3df032daac9236bf5682a42
Fixed: chromium:1275096
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306569
Commit-Queue: Jakob Gruber <[email protected]>
Reviewed-by: Leszek Swirski <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#78186}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3314822
Cr-Commit-Position: refs/branch-heads/9.7@{#32}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
Version 9.7.106.16
99bdf2f 
Change-Id: I02e86b4575ce85e767e655c9c9b0c559a6366ff6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3317024
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.7@{#33}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
@LeszekSwirski @ajklein
Merged: [compiler] Don't elide ChangeTaggedToInt32->ChangeInt31ToTagg…
bc50756 
…edSigned

(cherry picked from commit 4fae8b16802a416fe3aab0e7792fabe96cf1ecd8)

Bug: chromium:1278387
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Change-Id: Ia6b361f702261464e02785659a2a90cd2488a101
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3329666
Reviewed-by: Toon Verwaest <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.7@{#34}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
Version 9.7.106.17
1d9e6de 
Change-Id: I78b2271ce6a6c450662b00f056da6061d4e9d07a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3330897
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.7@{#35}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
@jakobkummerow
Merged: "[wasm] 32-bit platforms: lower kV8MaxWasmMemoryPages by 1"
fd38e83 
To make sure that Wasm memories don't exceed JSArrayBuffer size.
This change shouldn't affect real-world modules, because finding
enough contiguous address space to allocate that much memory is
virtually impossible anyway.

[email protected]

(cherry picked from commit 6d7ed2e8707cb865408da6a04d645c65553cd0b1)

Fixed: chromium:1242339
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Change-Id: Ie6bf129c5b3501b7e256e4358a257d9c202fa78c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3338663
Reviewed-by: Jakob Kummerow <[email protected]>
Reviewed-by: Thibaud Michaud <[email protected]>
Commit-Queue: Thibaud Michaud <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.7@{#36}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
Version 9.7.106.18
96e2674 
Change-Id: I257ba27852d65370568af5f1b41e6e0acbb858d9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3338320
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.7@{#37}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
@syg
Merged: [compiler] Fix typing JSLoadNamed of private brands
ee6a74e 
Private method loads are compiled to a named load of a private brand,
which always loads a BlockContext. This BlockContext holds the private
methods common to all instances of a class. TurboFan currently considers
JSLoadNamed to be of Type::NonInternal(). Private methods break this
assumption, since BlockContext is of Type::OtherInternal().

This CL changes the typing of JSLoadNamed of private brands to be
Type::OtherInternal().

Bug: v8:12500, chromium:1287475

(cherry picked from commit d19a707d148ca9b9ab9dd8c294fe4c49e99f31d4)

Change-Id: I91f39747bf9422bd419d299f44152f567d8be8db
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3399225
Reviewed-by: Maya Lekova <[email protected]>
Commit-Queue: Shu-yu Guo <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.7@{#38}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
Version 9.7.106.19
41de661 
Change-Id: I5e0ab7daa109fde98a3ee07869375d30ddbc658b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3398814
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.7@{#39}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
@syg
Merge: [ic] Add StoreOwnIC_Slow
8313f18 
This runtime function behaves like StoreDataPropertyInLiteral, except it
can throw, since it's also used for defining public class fields. Unlike
the literal use case, class field can end up throwing due to field
initializers doing things like freezing the instance.

Bug: chromium:1264828

(cherry picked from commit 1cc12b278e22d9ad4f0154e4b9e63cbb707b4657)

Change-Id: I3ea4d15ad9b906c26763f022c8e22b757fa80b6c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3401871
Reviewed-by: Igor Sheludko <[email protected]>
Reviewed-by: Shu-yu Guo <[email protected]>
Commit-Queue: Lutz Vahl <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.7@{#40}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
Version 9.7.106.20
7603c7a 
Change-Id: I96499227f2768dcae859c06fcd84a20c8481f2b4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3404536
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.7@{#41}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
@joyeecheung
Merge: [class] handle existing readonly properties in StoreOwnIC
f51b9df 
Previously, StoreOwnIC incorrectly reuses the [[Set]] semantics
when initializing public literal class fields and object literals in
certain cases (e.g. when there's no feedback).
This was less of an issue for object literals, but with public class
fields it's possible to define property attributes while the
instance is still being initialized, or to encounter existing static
"name" or "length" properties that should be readonly. This patch
fixes it by

1) Emitting code that calls into the slow stub when
   handling StoreOwnIC with existing read-only properties.
2) Adding extra steps in StoreIC::Store to handle such stores
   properly with [[DefineOwnProperty]] semantics.

Bug: v8:12421, v8:9888

(cherry picked from commit 80bbbb143c2449f7a2109424a937d1887043c9ee)

Change-Id: I6547320a1caba58c66ee1043cd3183a2de7cefef
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3402435
Reviewed-by: Igor Sheludko <[email protected]>
Commit-Queue: Lutz Vahl <[email protected]>
Cr-Commit-Position: refs/branch-heads/9.7@{#42}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
crocuis pushed a commit that referenced this issue May 17, 2022
Version 9.7.106.21
2a039c8 
Change-Id: I5c466d94ba2d6df1f8b72fff8adf610eb3e9aa80
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3405614
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.7@{#43}
Cr-Branched-From: 49162da-refs/heads/9.7.106@{#1}
Cr-Branched-From: a7e9b8f-refs/heads/main@{#77674}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@823639792