Swifttest setMetadata not working correctly for object metadata

[Mousaka]

Noticed that the setMetadata function (https://github.com/ncw/swift/blob/master/swifttest/server.go#L194) for the test version of swift object storage does not work the same way as swift object storage or like how the documentation reads when it comes to changing metadata on an object.

If you look at the documentation updating metadata on a container works different from when updating it on an object:

• Object https://github.com/ncw/swift/blob/master/swift.go#L2065
  • completely replaces metadata with provided metadata
• Container https://github.com/ncw/swift/blob/master/swift.go#L1286
  • updates current metadata with provided metadata, removes if a meta's value is ""

The swifttest's setMetadata function is used both for updating object and container and it works correctly for the container but not for updating metadata on an object.

Cheers

[ncw]

Is this causing you a problem?

Can you send a PR to fix?

[Mousaka]

@ncw It was causing some problem but also helped push me over to start testing with a connection to a real object store instead of the library's mock-version.

I might be able to send a PR next week!

[ncw]

I might be able to send a PR next week!

That would be great :-)