New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support registering an icon with a path to a file on disk #29

Open

cbirdsong opened this issue Apr 10, 2023 · 1 comment

Labels

Contributor

cbirdsong commented Apr 10, 2023

It would be nice if you could supply a file path when registering an icon instead of having to cram the SVG markup into a Javascript variable.

ndiego added the Enhancement label

JiveDig commented Dec 26, 2024 •

edited

Loading

I have a working version of this in a custom plugin. Here is the idea I'm playing with:

Creates a public endpoint for any theme icons in mytheme/assets/icons.
Recursively looks for icons (limited to 2 dirs depth):

mytheme/assets/icons/icon1.svg
mytheme/assets/icons/some_dir/icon2.svg
mytheme/assets/icons/some_dir/some_subdir/icon3.svg

It adds categories based on the dir hierarchy.

On local, it's take ~600ms to load 4354 icons from FontAwesome and Heroicons. Not sure how it would handle a large icon set on a real server.

Loading 1 Heroicons set (324 icons) takes ~150ms.

I'd love to have this filter only run when initiating the icon block, right now it runs immediately when the editor is loaded.

Anyone care to play with this code? Should we get it into a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment