"openFile: resource busy (file is locked)" when refactoring in place

[sinelaw]

I'm running:

hlint --refactor --refactor-options="-i"  bla.hs

and I'm consistently getting:

refactor: bla.hs: openFile: resource busy (file is locked)

Does hlint close the file before handing it over to refactor?

[ndmitchell]

I can't reproduce this, but I was indeed not closing the file properly, so sometimes it could have leaked (would have depended on when GC ran most likely). Can you try again with the git version?

[sinelaw]

Just tried latest master, still happens...

On Thu, Jan 21, 2016 at 4:01 PM, Neil Mitchell [email protected]
wrote:

I can't reproduce this, but I was indeed not closing the file properly, so
sometimes it could have leaked (would have depended on when GC ran most
likely). Can you try again with the git version?

—
Reply to this email directly or view it on GitHub
#207 (comment).

[ndmitchell]

Hmm. What OS/GHC version? Does it happen for all files? What about a simple file foo = concat . map succ?

[sinelaw]

GHC 7.10.3 installed using stack setup
Linux Mint / Ubuntu 14.04

Will do more tests later...

On Thu, Jan 21, 2016 at 4:37 PM, Noam Lewis [email protected] wrote:

Just tried latest master, still happens...

On Thu, Jan 21, 2016 at 4:01 PM, Neil Mitchell [email protected]
wrote:

I can't reproduce this, but I was indeed not closing the file properly,
so sometimes it could have leaked (would have depended on when GC ran most
likely). Can you try again with the git version?

—
Reply to this email directly or view it on GitHub
#207 (comment).

[ndmitchell]

Can you try running just refactor, without involving hlint, by calling refactor with the hlint output separately. I have a suspicion this might be a refactor only bug, cc @mpickering.

[sinelaw]

I tried doing that but couldn't figure out the right way. Do you run:

hlint file.hs | refactor

...or what?

On Thu, Jan 21, 2016 at 4:56 PM, Neil Mitchell [email protected]
wrote:

Can you try running just refactor, without involving hlint, by calling
refactor with the hlint output separately. I have a suspicion this might be
a refactor only bug, cc @mpickering https://github.com/mpickering.

—
Reply to this email directly or view it on GitHub
#207 (comment).

[ndmitchell]

hlint Sample.hs --serialise | refactor Sample.hs -i

(I had to look that up from the source code)

[sinelaw]

Yeah, looks like refactor fails even then. Still getting: openFile: resource busy (file is locked)

Opened issue mpickering/apply-refact#21