Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide what CORs we want to allow #186

Closed
Tracked by #250
, #242
...
DavidM-D opened this issue Jun 26, 2023 · 2 comments · Fixed by #270
Closed
Tracked by #250
, #242
...

Decide what CORs we want to allow #186

DavidM-D opened this issue Jun 26, 2023 · 2 comments · Fixed by #270
Assignees
@volovyks
Labels
Decision Further information or solutions are required Emerging Tech Emerging Tech flying formation at Pagoda Near BOS NEAR BOS team at Pagoda

Comments

@DavidM-D
Copy link
Contributor

During launch in a blind panic we allowed requests from all domains.

What are the downsides of this and what domains should we allow requests from?
@DavidM-D DavidM-D added the Decision Further information or solutions are required label Jun 26, 2023
@volovyks volovyks mentioned this issue Aug 8, 2023
Closed
@volovyks
Copy link
Collaborator

Looks like CORs protection can be a part of the Load Balancer. We can set it up after #250
Related info: https://cloud.google.com/compute/docs/reference/rest/v1/regionUrlMaps?authuser=1

@volovyks volovyks linked a pull request Aug 18, 2023 that will close this issue
Remove CORs TODO #270
Merged
@volovyks volovyks mentioned this issue Aug 18, 2023
Closed
@volovyks volovyks reopened this Sep 4, 2023
@trechriron trechriron added Near BOS NEAR BOS team at Pagoda Emerging Tech Emerging Tech flying formation at Pagoda labels Sep 7, 2023
@volovyks volovyks linked a pull request Sep 14, 2023 that will close this issue
Loadbalancer #289
Closed
@volovyks
Copy link
Collaborator

#289 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@volovyks volovyks

Labels
Decision Further information or solutions are required Emerging Tech Emerging Tech flying formation at Pagoda Near BOS NEAR BOS team at Pagoda
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove CORs TODO near/mpc
Loadbalancer near/mpc
3 participants
@trechriron @volovyks @DavidM-D