Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signAndSendTransactions should be able to handle multiple transactions without redirect #1044

Open
mattlockyer opened this issue Nov 22, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@mattlockyer
Copy link
Contributor

Describe the bug

NEARWallet
MyNearWallet

When using signAndSendTransactions (multiple) combined with actions that have no NEAR deposit (they should be able to be handled by access key); currently this still requires a redirect to the web wallet page for confirmation.

Instead, when all transactions in a call to signAndSendTransactions can be handled by access key (there is an access key and every action in each transaction has deposit: 0) these transactions should be executed in serial as regular calls to signAndSendTransaction.

To Reproduce
Steps to reproduce the behavior:

  1. Create 1 or more transactions with zero deposit
  2. Call wallet.signAndSendTransactions
  3. You are redirected

Expected behavior
No redirect, since the access key should be able to handle each transaction

@mattlockyer mattlockyer added the bug Something isn't working label Nov 22, 2022
@DamirSQA
Copy link

DamirSQA commented Dec 1, 2022

Hey, @mattlockyer thank you for raising this issue.

We have been investigating this issue and because we are using the requestSignTransactions of WalletConnection from near-api-js to sign and send multiple transactions we're not doing deposit check inside Wallet Selector.

We have done some work on this branch (supports the flow you suggested) but we're thinking it might be better for near-api-js to handle this internally since all browser wallets use the WalletConnection of near-api-js.

@andy-haynes andy-haynes transferred this issue from near/wallet-selector Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog 🥶
Development

No branches or pull requests

3 participants