Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you make authorization in a new window as a parameter of the requestSignIn function? #840

Closed
Ellweb3 opened this issue Apr 11, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@Ellweb3
Copy link

Ellweb3 commented Apr 11, 2022

Is your feature request related to a problem? Please describe. Yes. When developing plugins for other sites, it often fails to do authorization due to the fact that the near site cannot open in a frame.

Describe the solution you'd like

Make an option to open authorization in a new window like option parametr for wallet.requestSignIn like `

{"options": "newWindow": true}

or a new functionrequestSignInViaNewWindow`.

Describe alternatives you've considered The alternative can be changed in the standard command function window.location.assign(newUrl.toString()) to window.open(newUrl.toString(), "_parent"), but this may cause other problems

Additional context

@janewang janewang added the enhancement New feature or request label Jul 12, 2022
@vikinatora
Copy link
Collaborator

Will be resolved by #1260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants