Extending contract #319
Closed
Extending contract #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ailisp
reviewed
Dec 5, 2022
| ? "./build/counter-ts.wasm" | ||
| : "./build/counter.wasm" | ||
| ); | ||
| const counter = await root.devDeploy(counterContract); |
There was a problem hiding this comment.
oh I didn't see this:
Note 1: now it does not work, functions from the parent class are not generated or exported.
NearBindgen doesn't walk through parent class, it may be possible to identify extends pattern in our babel pass then recursively NearBindgen on parent class
There was a problem hiding this comment.
Yes, it should be possible (not tested), the question is - is it the best approach? I will experiment with this.
|
Closing in favor of #325 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's define if we want our contract to be extendable. Looks good, but it can lead to some issues with code generation (@waynenilsen ) and ABI (cc @itegulov).
@MaximusHaximus what is your opinion on this? Previously your advice was to avoid class extensions. But contract composability is a cool feature to have.
Note 1: now it does not work, functions from the parent class are not generated or exported.
Note 2: In Rust composability is achieved with macros: https://github.com/near/near-sdk-rs/blob/master/examples/non-fungible-token/nft/src/lib.rs#L103
Not something users want I think, especially in JS projects.
cc @ailisp