NFT Implementation simplification #321
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ailisp
reviewed
Dec 5, 2022
There was a problem hiding this comment.
It's a code style problem, I think both your approach and mine works.
In rust, these trait are required and impl of the traits appear outside impl MyNFT. In ts it appears together in the class body, so implements XXXInterface is optional. However, I think it would be nice to explicitly write these interfaces so if you forget implement any of the method, e.g. NonFungibleTokenEnumeration.nft_total_supply(), tsc and vscode will gives you an error:
|
Ok @ailisp , close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ailisp deleted redundant interfaces (tell me, if we need them for some reason).