From 3e0ddc63c229cd8e9f27f86e87211b3757d918e7 Mon Sep 17 00:00:00 2001 From: Michael Wei Date: Wed, 26 Oct 2022 01:24:57 -0700 Subject: [PATCH 1/3] bug: force ipv4 instead of localhost --- packages/js/dist/server/server.js | 2 +- packages/js/dist/utils.js | 2 +- packages/js/dist/worker.js | 4 ++-- packages/js/src/server/server.ts | 2 +- packages/js/src/utils.ts | 2 +- packages/js/src/worker.ts | 4 ++-- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/packages/js/dist/server/server.js b/packages/js/dist/server/server.js index 3323826b..21a52bb3 100644 --- a/packages/js/dist/server/server.js +++ b/packages/js/dist/server/server.js @@ -119,7 +119,7 @@ class SandboxServer { return this.config.port; } get rpcAddr() { - return `http://localhost:${this.port}`; + return `http://127.0.0.1:${this.port}`; } async start() { (0, internal_utils_1.debug)('Lifecycle.SandboxServer.start()'); diff --git a/packages/js/dist/utils.js b/packages/js/dist/utils.js index d44f8b8f..d5499e43 100644 --- a/packages/js/dist/utils.js +++ b/packages/js/dist/utils.js @@ -90,7 +90,7 @@ function urlConfigFromNetwork(network) { case 'sandbox': return { network: 'sandbox', - rpcAddr: 'http://localhost', + rpcAddr: 'http://127.0.0.1', }; case 'testnet': case 'mainnet': return configFromDomain(networkName); diff --git a/packages/js/dist/worker.js b/packages/js/dist/worker.js index c19c8c67..2a817cee 100644 --- a/packages/js/dist/worker.js +++ b/packages/js/dist/worker.js @@ -95,7 +95,7 @@ class SandboxWorker extends Worker { port, rm: false, refDir: null, - rpcAddr: `http://localhost:${port}`, + rpcAddr: `http://127.0.0.1:${port}`, }; } get provider() { @@ -118,7 +118,7 @@ class SandboxWorker extends Worker { }; } get rpcAddr() { - return `http://localhost:${this.config.port}`; + return `http://127.0.0.1:${this.config.port}`; } } exports.SandboxWorker = SandboxWorker; diff --git a/packages/js/src/server/server.ts b/packages/js/src/server/server.ts index 7ebf635e..ead9e387 100644 --- a/packages/js/src/server/server.ts +++ b/packages/js/src/server/server.ts @@ -126,7 +126,7 @@ export class SandboxServer { } get rpcAddr(): string { - return `http://localhost:${this.port}`; + return `http://127.0.0.1:${this.port}`; } async start(): Promise { diff --git a/packages/js/src/utils.ts b/packages/js/src/utils.ts index d5c199e3..9d5565c3 100644 --- a/packages/js/src/utils.ts +++ b/packages/js/src/utils.ts @@ -73,7 +73,7 @@ export function urlConfigFromNetwork(network: string | {network: string}): Clien case 'sandbox': return { network: 'sandbox', - rpcAddr: 'http://localhost', + rpcAddr: 'http://127.0.0.1', }; case 'testnet': diff --git a/packages/js/src/worker.ts b/packages/js/src/worker.ts index 39bbb2a5..f2673024 100644 --- a/packages/js/src/worker.ts +++ b/packages/js/src/worker.ts @@ -112,7 +112,7 @@ export class SandboxWorker extends Worker { port, rm: false, refDir: null, - rpcAddr: `http://localhost:${port}`, + rpcAddr: `http://127.0.0.1:${port}`, }; } @@ -138,6 +138,6 @@ export class SandboxWorker extends Worker { } private get rpcAddr(): string { - return `http://localhost:${this.config.port}`; + return `http://127.0.0.1:${this.config.port}`; } } From 40c8beb7ddd3199073197877f3e4c2c4b87b455e Mon Sep 17 00:00:00 2001 From: Michael Wei Date: Wed, 26 Oct 2022 08:14:08 -0700 Subject: [PATCH 2/3] ci: add node 18 to test matrix --- .github/workflows/tests-sandbox.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests-sandbox.yml b/.github/workflows/tests-sandbox.yml index 4df292b6..3459fceb 100644 --- a/.github/workflows/tests-sandbox.yml +++ b/.github/workflows/tests-sandbox.yml @@ -9,7 +9,7 @@ jobs: strategy: matrix: platform: [ubuntu-latest, macos-latest] - node-version: [14, 16] + node-version: [14, 16, 18] runs-on: ${{ matrix.platform }} steps: - uses: actions/checkout@v2 From fd3a37183b943dfd6cd410da48cecc910624211b Mon Sep 17 00:00:00 2001 From: gagdiez Date: Thu, 25 Jan 2024 12:43:07 +0100 Subject: [PATCH 3/3] Trigger CI --- .github/workflows/tests-sandbox.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests-sandbox.yml b/.github/workflows/tests-sandbox.yml index 3459fceb..479e7acf 100644 --- a/.github/workflows/tests-sandbox.yml +++ b/.github/workflows/tests-sandbox.yml @@ -9,7 +9,7 @@ jobs: strategy: matrix: platform: [ubuntu-latest, macos-latest] - node-version: [14, 16, 18] + node-version: [14, 16, 18, 20] runs-on: ${{ matrix.platform }} steps: - uses: actions/checkout@v2