Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

state sync: refactor structures identifying State Parts #12104

Open
saketh-are opened this issue Sep 17, 2024 · 0 comments
Open

state sync: refactor structures identifying State Parts #12104

saketh-are opened this issue Sep 17, 2024 · 0 comments
Assignees

Comments

@saketh-are
Copy link
Collaborator

In state sync a state part is generally identified by:

  • A shard id
  • A sync hash
  • A part id

In various places we use types such as tuple (ShardId, CryptoHash, u64) without named members, and the order in which the fields are presented is inconsistent between places. We should improve the consistency and consider a proper struct with named members for better maintainability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant