From e63024a204e90704999af19fa0aa9ed3f7ff95f2 Mon Sep 17 00:00:00 2001
From: Darun Seethammagari <darun@near.org>
Date: Wed, 20 Dec 2023 09:45:57 -0800
Subject: [PATCH] fix: Prune Unnecessary Logs (#465)

Logs are causing machine to run out of space, leading to crashes. I've
removed some logs which are not particularly helpful for debugging
problems anymore. These logs also tend to run basically every single
iteration, bloating logs both on machine and in GCP.
---
 runner/src/dml-handler/dml-handler.ts | 15 ---------------
 runner/src/indexer/indexer.ts         |  3 +--
 runner/src/stream-handler/worker.ts   |  1 -
 3 files changed, 1 insertion(+), 18 deletions(-)

diff --git a/runner/src/dml-handler/dml-handler.ts b/runner/src/dml-handler/dml-handler.ts
index 15873e14f..a3519a15d 100644
--- a/runner/src/dml-handler/dml-handler.ts
+++ b/runner/src/dml-handler/dml-handler.ts
@@ -37,9 +37,6 @@ export default class DmlHandler {
     const query = `INSERT INTO ${schemaName}."${tableName}" (${keys.join(', ')}) VALUES %L RETURNING *`;
 
     const result = await wrapError(async () => await this.pgClient.query(this.pgClient.format(query, values), []), `Failed to execute '${query}' on ${schemaName}."${tableName}".`);
-    if (result.rows?.length === 0) {
-      console.log('No rows were inserted.');
-    }
     return result.rows;
   }
 
@@ -53,9 +50,6 @@ export default class DmlHandler {
     }
 
     const result = await wrapError(async () => await this.pgClient.query(this.pgClient.format(query), values), `Failed to execute '${query}' on ${schemaName}."${tableName}".`);
-    if (!(result.rows && result.rows.length > 0)) {
-      console.log('No rows were selected.');
-    }
     return result.rows;
   }
 
@@ -69,9 +63,6 @@ export default class DmlHandler {
     const query = `UPDATE ${schemaName}."${tableName}" SET ${updateParam} WHERE ${whereParam} RETURNING *`;
 
     const result = await wrapError(async () => await this.pgClient.query(this.pgClient.format(query), queryValues), `Failed to execute '${query}' on ${schemaName}."${tableName}".`);
-    if (!(result.rows && result.rows.length > 0)) {
-      console.log('No rows were selected.');
-    }
     return result.rows;
   }
 
@@ -87,9 +78,6 @@ export default class DmlHandler {
     const query = `INSERT INTO ${schemaName}."${tableName}" (${keys.join(', ')}) VALUES %L ON CONFLICT (${conflictColumns.join(', ')}) DO UPDATE SET ${updatePlaceholders} RETURNING *`;
 
     const result = await wrapError(async () => await this.pgClient.query(this.pgClient.format(query, values), []), `Failed to execute '${query}' on ${schemaName}."${tableName}".`);
-    if (result.rows?.length === 0) {
-      console.log('No rows were inserted or updated.');
-    }
     return result.rows;
   }
 
@@ -100,9 +88,6 @@ export default class DmlHandler {
     const query = `DELETE FROM ${schemaName}."${tableName}" WHERE ${param} RETURNING *`;
 
     const result = await wrapError(async () => await this.pgClient.query(this.pgClient.format(query), values), `Failed to execute '${query}' on ${schemaName}."${tableName}".`);
-    if (!(result.rows && result.rows.length > 0)) {
-      console.log('No rows were deleted.');
-    }
     return result.rows;
   }
 }
diff --git a/runner/src/indexer/indexer.ts b/runner/src/indexer/indexer.ts
index f70cb6983..4bb631bdd 100644
--- a/runner/src/indexer/indexer.ts
+++ b/runner/src/indexer/indexer.ts
@@ -65,7 +65,7 @@ export default class Indexer {
         const indexerFunction = functions[functionName];
 
         const runningMessage = `Running function ${functionName} on block ${blockHeight}` + (isHistorical ? ' historical backfill' : `, lag is: ${lag?.toString()}ms from block timestamp`);
-        console.log(runningMessage); // Print the running message to the console (Lambda logs)
+        console.log(runningMessage); // Print the running message to the console
 
         simultaneousPromises.push(this.writeLog(functionName, blockHeight, runningMessage));
 
@@ -192,7 +192,6 @@ export default class Indexer {
     }
 
     const tableNamesArray = Array.from(tableNames);
-    console.log('Retrieved the following table names from schema: ', tableNamesArray);
     return Array.from(tableNamesArray);
   }
 
diff --git a/runner/src/stream-handler/worker.ts b/runner/src/stream-handler/worker.ts
index 51305edb2..13947d0ad 100644
--- a/runner/src/stream-handler/worker.ts
+++ b/runner/src/stream-handler/worker.ts
@@ -68,7 +68,6 @@ async function blockQueueProducer (workerContext: WorkerContext, streamKey: stri
       streamMessageStartId = '0';
       continue;
     }
-    console.log(`Fetched ${messages?.length} messages from stream ${streamKey}`);
 
     for (const streamMessage of messages) {
       const { id, message } = streamMessage;