Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle new StartBlock config options #521

Closed
Tracked by #396
morgsmccauley opened this issue Jan 23, 2024 · 0 comments · Fixed by #553
Closed
Tracked by #396

Handle new StartBlock config options #521

morgsmccauley opened this issue Jan 23, 2024 · 0 comments · Fixed by #553
Assignees
@morgsmccauley
Labels
component: Coordinator

Comments

@morgsmccauley
Copy link
Collaborator

morgsmccauley commented Jan 23, 2024 •
edited
Loading

Context: #517 (comment)

We should start using the updated StartFrom options as opposed to the start_from_block parameter.
@morgsmccauley morgsmccauley mentioned this issue Jan 23, 2024
Closed
@darunrs darunrs mentioned this issue Jan 25, 2024
Merged
darunrs added a commit that referenced this issue Jan 25, 2024
@darunrs
feat: Enable Block Streams Start from V1 Interruption (#517)
920407a 
Coordinator V2 currently defaults to starting block streams with the
start_block_height value populated in the registry. In order for a
smooth migration from V1 to V2, we instead want Coordinator V2 to create
block streams starting where the current indexers left off.

Coordinator V1 now writes a last_published_block value for all indexers
it manages on each matching block.

Coordinator V2's start_block_height setting workflow needs refactoring.
This is due to the fact that the exisitng flow defauls to using
start_block_height as its present in the registry even after we begin
processing a stream from that block height. We need to refactor the flow
to ensure we use the start block height once, and otherwise use redis
last published block height, or fallback if not present.

New flow to handle edge cases will be tracked by
#521.
@morgsmccauley morgsmccauley changed the title Ensure historical backfills are only started once Handle "From Interruption" option Jan 30, 2024
@morgsmccauley morgsmccauley changed the title Handle "From Interruption" option Handle new "Start From" config options Jan 30, 2024
@morgsmccauley morgsmccauley changed the title Handle new "Start From" config options Handle new StartBlock config options Feb 7, 2024
@morgsmccauley morgsmccauley linked a pull request Feb 7, 2024 that will close this issue
feat: Handle StartBlock options within Coordinator & Block Streamer #553
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@morgsmccauley morgsmccauley

Labels
component: Coordinator
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Handle StartBlock options within Coordinator & Block Streamer near/queryapi
2 participants
@morgsmccauley @darunrs