Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contract download chain replication #226

Closed
ixje opened this issue Apr 7, 2022 · 4 comments
Closed

contract download chain replication #226

ixje opened this issue Apr 7, 2022 · 4 comments
Labels
duplicate This issue or pull request already exists

Comments

@ixje
Copy link
Contributor

ixje commented Apr 7, 2022

see point 2. of #209 (comment)

@devhawk
Copy link
Contributor

devhawk commented Apr 21, 2022

@ixje Isn't this a duplicate of #225 ?

@devhawk devhawk added the question Further information is requested label Apr 21, 2022
@ixje
Copy link
Contributor Author

ixje commented Apr 22, 2022

Not necessarily. There is a lot of overlap for OnlineNode's but not for offline or batch ones. The difference might be small enough to merge the 2 issues though. If we keep them separate then this issue should be resolved before #225 .

@devhawk devhawk added duplicate This issue or pull request already exists and removed question Further information is requested labels Aug 15, 2022
@devhawk
Copy link
Contributor

devhawk commented Aug 15, 2022

I'm going to close this issue as a dupe of #255.

@ixje
Copy link
Contributor Author

ixje commented Aug 15, 2022

This is not a duplicate though.
iirc #225 is about downloading from a source network into a multi-node private network, whereas this issue is about how a client connected to the private network that had a contract downloaded on its chain will get the new state information because there is no deploy transaction. Solving this issue could however automatically solve #225

Either way, I think this issue has more context than #225 and should therefore take precedence over #225. just my 2 cents

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants