Move EnhancedGraphAPI into its own component

[peterneubauer]

@NielsHoogeveen I think we should release a first version of graph-collections. Before doing that, I think we should take out the EnhancedGraphAPI and put it in its own component, maybe then depend on it instead to keep concerns clean.

WDYT?

[brycenz]

Which reminds me that there are a number of changes I need to submit back.
I have been running graph collections in production now for a few months,
had to make a few changes, and have some insights into what not to do with
it.

On Fri, Dec 23, 2011 at 3:32 AM, Peter Neubauer <
[email protected]

wrote:

@NielsHoogeveen I think we should release a first version of
graph-collections. Before doing that, I think we should take out the
EnhancedGraphAPI and put it in its own component, maybe then depend on it
instead to keep concerns clean.

WDYT?

---

Reply to this email directly or view it on GitHub:
#12

[NielsHoogeveen]

Looking forward to your changes, once you submit them, I will remove the Enhanced API stuff.
Niels

Date: Thu, 22 Dec 2011 12:31:53 -0800
From: [email protected]
To: [email protected]
Subject: Re: [graph-collections] Move EnhancedGraphAPI into its own component (#12)

Which reminds me that there are a number of changes I need to submit back.
I have been running graph collections in production now for a few months,
had to make a few changes, and have some insights into what not to do with
it.

On Fri, Dec 23, 2011 at 3:32 AM, Peter Neubauer <
[email protected]

wrote:

@NielsHoogeveen I think we should release a first version of
graph-collections. Before doing that, I think we should take out the
EnhancedGraphAPI and put it in its own component, maybe then depend on it
instead to keep concerns clean.

WDYT?

---

Reply to this email directly or view it on GitHub:
#12

---

Reply to this email directly or view it on GitHub:
#12 (comment)

[NielsHoogeveen]

I will removed the Enhanced API stuff, hopefully this week.
Looking forward seeing this become official.
Niels

Date: Thu, 22 Dec 2011 06:32:47 -0800
From: [email protected]
To: [email protected]
Subject: [graph-collections] Move EnhancedGraphAPI into its own component (#12)

@NielsHoogeveen I think we should release a first version of graph-collections. Before doing that, I think we should take out the EnhancedGraphAPI and put it in its own component, maybe then depend on it instead to keep concerns clean.

WDYT?

---

Reply to this email directly or view it on GitHub:
#12

[peterneubauer]

Yu,
Also, did you see the nice lab-day outcome on indexing? An
IndexProvider backed by the Timeline graph collection! I think you
will like and get in more stuff like range trees etc :)

https://github.com/neo4j/graph-collections/blob/master/src/test/java/org/neo4j/collections/indexprovider/TimelineIndexProviderTest.java

/peter

On Thu, Dec 22, 2011 at 9:54 PM, Niels Hoogeveen
[email protected]
wrote:

I will removed the Enhanced API stuff, hopefully this week.
Looking forward seeing this become official.
Niels

Date: Thu, 22 Dec 2011 06:32:47 -0800
From: [email protected]
To: [email protected]
Subject: [graph-collections] Move EnhancedGraphAPI into its own component (#12)

@NielsHoogeveen I think we should release a first version of graph-collections. Before doing that, I think we should take out the EnhancedGraphAPI and put it in its own component, maybe then depend on it instead to keep concerns clean.

WDYT?

---

Reply to this email directly or view it on GitHub:
#12

---

Reply to this email directly or view it on GitHub:
#12 (comment)

[NielsHoogeveen]

I checked out the Enhanced API stuff in Graph-collections, but there are a couple of dependencies in SortedTree for property comparison. Maybe it's best not to remove all of Enhanced API but keep the bare minimum, while getting rid of the rest.

Date: Fri, 23 Dec 2011 01:29:39 -0800
From: [email protected]
To: [email protected]
Subject: Re: [graph-collections] Move EnhancedGraphAPI into its own component (#12)

Yu,
Also, did you see the nice lab-day outcome on indexing? An
IndexProvider backed by the Timeline graph collection! I think you
will like and get in more stuff like range trees etc :)

https://github.com/neo4j/graph-collections/blob/master/src/test/java/org/neo4j/collections/indexprovider/TimelineIndexProviderTest.java

/peter

On Thu, Dec 22, 2011 at 9:54 PM, Niels Hoogeveen
[email protected]
wrote:

I will removed the Enhanced API stuff, hopefully this week.
Looking forward seeing this become official.
Niels

Date: Thu, 22 Dec 2011 06:32:47 -0800
From: [email protected]
To: [email protected]
Subject: [graph-collections] Move EnhancedGraphAPI into its own component (#12)

@NielsHoogeveen I think we should release a first version of graph-collections. Before doing that, I think we should take out the EnhancedGraphAPI and put it in its own component, maybe then depend on it instead to keep concerns clean.

WDYT?

---

Reply to this email directly or view it on GitHub:
#12

---

Reply to this email directly or view it on GitHub:
#12 (comment)

---

Reply to this email directly or view it on GitHub:
#12 (comment)

[peterneubauer]

Niels,
yes I am just thinking that the Enhanced API is worth its own
component so people don't get confused and we can put a number of
collections behind the Index API to be easily usable from Cypher and
Java.

Btw merry X-Mas everyone!

On Fri, Dec 23, 2011 at 7:05 PM, Niels Hoogeveen
[email protected]
wrote:

I checked out the Enhanced API stuff in Graph-collections, but there are a couple of dependencies in SortedTree for property comparison. Maybe it's best not to remove all of Enhanced API but keep the bare minimum, while getting rid of the rest.

Date: Fri, 23 Dec 2011 01:29:39 -0800
From: [email protected]
To: [email protected]
Subject: Re: [graph-collections] Move EnhancedGraphAPI into its own component (#12)

Yu,
Also, did you see the nice lab-day outcome on indexing? An
IndexProvider backed by the Timeline graph collection! I think you
will like and get in more stuff like range trees etc :)

https://github.com/neo4j/graph-collections/blob/master/src/test/java/org/neo4j/collections/indexprovider/TimelineIndexProviderTest.java

/peter

On Thu, Dec 22, 2011 at 9:54 PM, Niels Hoogeveen
[email protected]
wrote:

I will removed the Enhanced API stuff, hopefully this week.
Looking forward seeing this become official.
Niels

Date: Thu, 22 Dec 2011 06:32:47 -0800
From: [email protected]
To: [email protected]
Subject: [graph-collections] Move EnhancedGraphAPI into its own component (#12)

@NielsHoogeveen I think we should release a first version of graph-collections. Before doing that, I think we should take out the EnhancedGraphAPI and put it in its own component, maybe then depend on it instead to keep concerns clean.

WDYT?

---

Reply to this email directly or view it on GitHub:
#12

---

Reply to this email directly or view it on GitHub:
#12 (comment)

---

Reply to this email directly or view it on GitHub:
#12 (comment)

---

Reply to this email directly or view it on GitHub:
#12 (comment)

[NielsHoogeveen]

Bryce,

I finally had an opportunity to try out part of the code in my own application and I ran into an issue with SortedTree. When looking up an existing tree, a constructor is called which has a single Node (the base node) as its only argument.

This didn't work for me, since the Comparator supplied when creating the index, takes an argument (and therefore cannot be reinstantiated with a simple class load/newinstance mechanism). I think we should provide an additional constructor for existing indexes that also takes the Comparator as argument, so Comparators that take arguments in their constructor can be used. What are your thoughts about this.

Niels