You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Put a breakpoint in both the constructors of ClientboundLevelParticlesPacket
Fall on any blocks from some distance
Observe that the pos field of the pos field of the object referenced to by ClientboundLevelParticlesPacket#particle is non-null (and the position of the fallen-on block) at the end of the "logical server side" constructor and null at the end of the constructor used by the netty thread.
Description of issue:
The position of the fallen-on block is not know on the client. If the block model depend on ModelData to retrive the correct particle it is unable to do so since the correct ModelData can't be retrived (ModelData.EMPTY is used instead)
Having discussed this with XFactHD on discord, it looks like this problem originated at the introduction of the pos field in BlockParticleOption
Z
The text was updated successfully, but these errors were encountered:
…when fall damage particles are requested for ModelData-aware blocks (see neoforged/NeoForge#1629). To address this, a "fallback" ModelData option has been added, which will be used in cases where the requested ModelData returns empty.
ZeroNoRyouki
added a commit
to ZeroNoRyouki/ExtremeReactors2
that referenced
this issue
Oct 27, 2024
…when fall damage particles are requested for ModelData-aware blocks (see neoforged/NeoForge#1629). To address this, a "fallback" ModelData option has been added, which will be used in cases where the requested ModelData returns empty.
ZeroNoRyouki
added a commit
to ZeroNoRyouki/ExtremeReactors2
that referenced
this issue
Oct 27, 2024
I've made a PR to fix this in 1.21.3, though I'm not sure yet how to deal with it in 1.21.1 since the fix used in the PR is technically a network compatibility break.
Minecraft Version: 1.21.1
NeoForge Version: 21.1.22 (dev-env) / 21.1.72 (production)
Steps to Reproduce:
Description of issue:
The position of the fallen-on block is not know on the client. If the block model depend on ModelData to retrive the correct particle it is unable to do so since the correct ModelData can't be retrived (ModelData.EMPTY is used instead)
Having discussed this with XFactHD on discord, it looks like this problem originated at the introduction of the pos field in BlockParticleOption
Z
The text was updated successfully, but these errors were encountered: