Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: triple logging of some errors #9020

Closed
koivunej opened this issue Sep 17, 2024 · 0 comments · Fixed by #9277
Closed

proxy: triple logging of some errors #9020

koivunej opened this issue Sep 17, 2024 · 0 comments · Fixed by #9277
Assignees
Labels
c/cloud/proxy Component: cloud: proxy t/bug Issue Type: Bug

Comments

@koivunej
Copy link
Member

koivunej commented Sep 17, 2024

In nightly prodlike benchmark.

2024-09-17T07:57:45.038233Z ERROR connect_request{protocol=tcp session_id=25a984bf-8c2f-4eca-bb6c-68cf3385c675 peer_addr=3.20.172.197 ep=ep-orange-boat-w11dj1ty role=neondb_owner}:connect_to_compute: could not connect to compute node error=Postgres(Error { kind: Db, cause: Some(DbError { severity: "FATAL", parsed_severity: Some(Fatal), code: SqlState(E3D000), message: "database \"neondb\" does not exist", detail: None, hint: None, position: None, where_: None, schema: None, table: None, column: None, datatype: None, constraint: None, file: Some("postinit.c"), line: Some(1019), routine: Some("InitPostgres") }) })
2024-09-17T07:57:45.045597Z ERROR connect_request{protocol=tcp session_id=25a984bf-8c2f-4eca-bb6c-68cf3385c675 peer_addr=3.20.172.197 ep=ep-orange-boat-w11dj1ty role=neondb_owner}:connect_to_compute: couldn't connect to compute node error=Postgres(Error { kind: Db, cause: Some(DbError { severity: "FATAL", parsed_severity: Some(Fatal), code: SqlState(E3D000), message: "database \"neondb\" does not exist", detail: None, hint: None, position: None, where_: None, schema: None, table: None, column: None, datatype: None, constraint: None, file: Some("postinit.c"), line: Some(1019), routine: Some("InitPostgres") }) }) num_retries=1 retriable=false
2024-09-17T07:57:45.045674Z ERROR connect_request{protocol=tcp session_id=25a984bf-8c2f-4eca-bb6c-68cf3385c675 peer_addr=3.20.172.197 ep=ep-orange-boat-w11dj1ty role=neondb_owner}: per-client task finished with an error: Couldn't connect to compute node: db error: FATAL: database "neondb" does not exist

connect_to_compute: could not connect to compute node

error!(error = ?err, "could not connect to compute node");

connect_to_compute: couldn't connect to compute node

error!(error = ?e, num_retries, retriable = false, "couldn't connect to compute node");

Found while looking all warnings and errors in the eu-west-1 region. I later gave up on that idea :)

Expectation is that that a single error would only be logged once, and at least here it seems per session id that the same action was logged three times.

@koivunej koivunej added c/cloud/proxy Component: cloud: proxy t/bug Issue Type: Bug labels Sep 17, 2024
awarus added a commit that referenced this issue Oct 4, 2024
Fixes (#9020)
 - Use the compute::COULD_NOT_CONNECT for connection error message;
 - Eliminate logging for one connection attempt;
 - Typo fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/cloud/proxy Component: cloud: proxy t/bug Issue Type: Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants