Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: provide more context in GCResult and clarify timeline_gc caller intent. #9063

Open
yliang412 opened this issue Sep 19, 2024 · 0 comments
Labels
a/test Area: related to testing c/storage/pageserver Component: storage: pageserver

Comments

@yliang412
Copy link
Contributor

Adapted from #9024 (comment):

We have many tests where we do manual PageserverHttpClien.timeline_gc and expect GC not to be skipped or some layer is removed. It is possible to query the returned GcResult to learn about whether some layers are removed, but we don't have enough information to know whether GC is skipped.

We also want to differentiate "skipping GC" from "doing GC but removed 0 layers" since during a GC iteration we refresh per timeline GCInfo even if we removed no layers.

We should provide more information (maybe the gc blocking reasons) in the return value and use assertion on Python side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/test Area: related to testing c/storage/pageserver Component: storage: pageserver
Projects
None yet
Development

No branches or pull requests

1 participant