Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: use msgpackr #221

Open
justinmk opened this issue Jul 17, 2023 · 2 comments
Open

deps: use msgpackr #221

justinmk opened this issue Jul 17, 2023 · 2 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@justinmk
Copy link
Member

Evaluate if it's worth switching to https://www.npmjs.com/package/msgpackr instead of our current msgpack dependency.
@justinmk justinmk added the dependencies Pull requests that update a dependency file label Jul 17, 2023
@gjf7
Copy link
Contributor

gjf7 commented Oct 18, 2024 •
edited
Loading

It appears that msgpackr does not support using 0 as an extension type code. kriszyp/msgpackr#150

@justinmk
Copy link
Member Author

Thank you for mentioning that. Arg, I really wish we hadn't played with "extension types".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@justinmk @gjf7