Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findNvim - Add an option to "stop searching after a match" #370

Closed
xiyaowong opened this issue Jun 19, 2024 · 1 comment · Fixed by #397
Closed

findNvim - Add an option to "stop searching after a match" #370

xiyaowong opened this issue Jun 19, 2024 · 1 comment · Fixed by #397
Labels

Comments

@xiyaowong
Copy link
Contributor

I think this title needs no further explanation. :)

@justinmk justinmk added the enhancement feature label Jun 19, 2024
@justinmk
Copy link
Member

justinmk commented Jun 19, 2024

It probably should do this by default, rather than making it optional.

The main (intended) reason that findNvim returns multiple results is for the case where none of the results are valid, and then the caller can mention these results in a user-facing error message, like:

Nvim X.Y not found. Found:

- /usr/local/bin/nvim 0.3 (too old)
- /foo/bar/nvim (failed to run)
- ...

Edit: OTOH, maybe it's useful to be able to select the most-recent Nvim, when there are multiple valid matches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants