feat: add firstMatch option for findNvim #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk
reviewed
Sep 19, 2024
justinmk
approved these changes
Sep 19, 2024
justinmk
reviewed
Sep 19, 2024
gjf7
commented
Sep 20, 2024
justinmk
reviewed
Sep 20, 2024
justinmk
reviewed
Sep 20, 2024
justinmk
reviewed
Sep 20, 2024
justinmk
reviewed
Sep 20, 2024
justinmk
added a commit
that referenced
this pull request
Sep 20, 2024
Problem: Code coverage is not counted for Windows. For example, in #397 codecov flags the `if (LOCALAPPDATA)` branches. Solution: Run codecov on all platforms (but only for a single node version, to be frugal).
|
The codecov complaints about the Windows codepaths, should be fixed after #398 |
justinmk
added a commit
that referenced
this pull request
Sep 20, 2024
Problem: Code coverage is not counted for Windows. For example, in #397 codecov flags the `if (LOCALAPPDATA)` branches. Solution: Run codecov on all platforms (but only for a single node version, to be frugal).
justinmk
changed the title
justinmk
reviewed
Sep 20, 2024
justinmk
approved these changes
Sep 20, 2024
|
@justinmk Thanks for your patient review! This is my first time contributing to node-client, and I'm so excited. |
|
It's great to have some help around here :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #370 and #267
Introducing a new 'stopOnFirstMatch' option for the findNvim function, which helps reduce the number of system calls when the caller only need one valid match. Additionally, the search now includes common locations where Neovim might be installed.